TypeShade
Rule 13.5
Chapter 13, Change control Review
A hot-spot file must be edited only after reading what the branch already did to it, and a claim of a § number, a TS80xx code, or an INTRINSICS row must be made in the issue before the branch is opened.
The rule text and the parts under it are the compiler's own English, as the design document writes them.
Rationale
two branches editing one of these at once conflict on merge, and two claims of one number conflict forever.
Derives from
#162 (“hot-spot files” and “claim before you write”); the list is src/core/intrinsics.ts (append-only), src/language-service/ambient.ts and docs.ts, src/core/ir/types.ts and nodes.ts, src/compiler/ts/lower/expression-call.ts and function.ts, src/core/backends/wgsl.ts and glsl.ts, src/core/passes/required-caps.ts and the capability witness table, src/core/intrinsic-coverage.test.ts, docs/use-typeshade-surface.md § numbering, CHANGELOG.md, examples/_shade.ts, docs/roadmap.md.
How it is verified
Held by review. No file checks it, and the rule names review as what holds it.
Where the rule says the compiler enforces it:
review.
See also
- Rule 13.4 Test
- Rule 13.6 Test
- Design rules
- Error codes
Source
The rule at commit 26de7be8:
docs/language-design.md:1317(the design document)reqs/rules/RULE-1305.md(its traceability item)